[CI] Fix build workflows and stale CI references - #157
Merged
Conversation
The Configure step used a YAML folded scalar (run: >), which joins every line into one shell command. The inline comment above the socket-test flag turned everything after it into a shell comment, silently dropping -DWITH_NET_TESTS=0, -DSOAP=1, -DSCRIPT_LIB_ELUNA=1, -DSCRIPT_LIB_SD3=1, -DPLAYERBOTS=1, and -DPCH=0/1. Moved the comment above the step instead. Also drop the CCACHE_DIR/SCCACHE_DIR overrides and repoint BUILD_DIR at runner.temp: the previous ../ccache and ../build paths contain '..', which actions/cache refuses to save, so the compiler cache never persisted across runs.
SlProWeb's Win64OpenSSL installer places provider DLLs (legacy.dll, default.dll) beside openssl.exe, but the binary's compiled MODULESDIR still names the default installation path. Set OPENSSL_MODULES so the providers actually load. Ports the fix already carried on mangosfour.
The [10] link definition pointed at core_build.yml, which does not exist under .github/workflows/. Point it at core_linux_build.yml, the file the adjacent badge already references.
The runner context is not available in jobs.<job_id>.env, so ${{ runner.temp }}
there makes the whole workflow file invalid and GitHub refuses to run it.
BUILD_DIR is never handed to actions/cache, so it does not need to avoid '..';
only CCACHE_DIR and SCCACHE_DIR did, and those stay removed.
|
✅ Build Mangos ONE Server 22.04.122 completed (commit 278ea56b42 by @r-log) |
|
✅ Build Mangos ONE Server 22.04.124 completed (commit 8d8ed33afb by @r-log) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent defects in the GitHub Actions build workflows. No AppVeyor configuration is touched.
1. Six configure flags are silently discarded.
The
Configurestep uses a YAML folded scalar (run: >), which joins every line into a single shell command. bash then treats the embedded#comment — and everything after it — as a comment, so these never reach cmake:Confirmed in the job logs: the configure summary prints
Support for SOAP : No (default)despite-DSOAP=1being written. Fixed by moving the comment above the step; the comment's meaning is unchanged andrun: >is kept.2. The compiler cache has never persisted.
CCACHE_DIR/SCCACHE_DIRcontained.., whichactions/cacherejects at save time:Every subsequent run reports
No cache foundand rebuilds cold. Measured hit rates: ccache 1.5–1.9%, sccache 0.00%. The overrides are removed soccache-actionmanages its own directory.BUILD_DIRmoves to${{ runner.temp }}rather than being deleted — it must stay outside the workspace or the "Verify the working tree is clean" step fails.3. Stale CI references.
The README links
core_build.yml, which does not exist; the workflow iscore_linux_build.yml.Verification: each workflow was parsed with PyYAML and the
Configurestep folded exactly as the shell receives it, asserting no#survives, all six flags are present, and no..remains in the command or in any job-levelenv.This change is