Skip to content

Fix bundled OpenSSL legacy provider startup on Windows - #470

Merged
MadMaxMangos merged 3 commits into
masterfrom
codex/openssl-release-repair
Aug 2, 2026
Merged

Fix bundled OpenSSL legacy provider startup on Windows#470
MadMaxMangos merged 3 commits into
masterfrom
codex/openssl-release-repair

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • discover a bundled ossl-modules\legacy.dll relative to the running daemon on Windows
  • preserve an explicitly configured OPENSSL_MODULES value
  • validate provider/runtime major versions and confirm RC4 is available
  • exercise the release-style layout in focused tests, including flat OpenSSL module installations

Root cause

OpenSSL 3 loads the legacy provider as a separate module. Release users could have libcrypto-3-x64.dll beside the daemons but still fail to start because the provider search path pointed at a machine-local OpenSSL installation rather than the extracted release.

User impact

Windows release ZIPs can run realmd and mangosd without requiring a system-wide OpenSSL installation, provided the release contains the matching ossl-modules\legacy.dll.

The AppVeyor packaging changes that place libcrypto-3-x64.dll and ossl-modules\legacy.dll in the ZIP are maintained separately from this repository.

Validation

  • MSVC realmd and mangos_tests targets built successfully
  • focused OpenSSL provider tests: 2/2 passed (164 total tests available)
  • scoped cross-model review completed with no blocking or important findings
  • no database changes required

This change is Reviewable

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@MadMaxMangos
MadMaxMangos marked this pull request as ready for review August 2, 2026 14:25
@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos
MadMaxMangos merged commit 4925c95 into master Aug 2, 2026
8 checks passed
@MadMaxMangos
MadMaxMangos deleted the codex/openssl-release-repair branch August 2, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants