Skip to content

Harden Playerbot authorization and random bot provisioning - #478

Merged
MadMaxMangos merged 9 commits into
masterfrom
fix/pr476-adversarial-findings
Aug 20, 2026
Merged

Harden Playerbot authorization and random bot provisioning#478
MadMaxMangos merged 9 commits into
masterfrom
fix/pr476-adversarial-findings

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • restrict player-owned bot authority to the owner, with only follow, stay, and attack delegated to same-subgroup players
  • constrain generated mounts to Classic race/class/riding eligibility and validate the loaded DBC spell shape before learning one
  • create only missing playable Classic classes and safely reject unsupported or empty class/race mappings
  • authorize named raid warnings against the fixed warning command that is actually dispatched

This is a focused follow-up to #476 and closes the adversarial review findings against commit 1817ae11.

Scope

  • random-bot trust behavior remains unchanged
  • no Warden files or Warden commits are included
  • no database migration or configuration change is required

Verification

  • RelWithDebInfo mangosd and mangos_tests builds
  • CTest: 15/15 passed
  • unit harness: 330/330 passed
  • focused policy tests: security 10/10, mounts 7/7, random classes 6/6
  • repository codestyle and git diff --check
  • bounded Claude Opus 5 max reviews: APPROVE for each logical change

This change is Reviewable

@codacy-production

codacy-production Bot commented Aug 20, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 64 complexity · 0 duplication

Metric Results
Complexity 64
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos
MadMaxMangos marked this pull request as ready for review August 20, 2026 13:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e18c057938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/modules/Bots/playerbot/PlayerbotAI.cpp

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3276b1ae6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/modules/Bots/playerbot/PlayerbotSecurityPolicy.h Outdated
@MadMaxMangos
MadMaxMangos merged commit 50867f6 into master Aug 20, 2026
7 of 8 checks passed
@MadMaxMangos
MadMaxMangos deleted the fix/pr476-adversarial-findings branch August 20, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants