queue-runner: ssh fixes#34
Draft
plumj-am wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
Actually, it's probably better to keep the full thing for the store. I feel like I already tried this which is why I stripped it but I'll try again Edit: Ignore this, the description above has been updated. |
Ensures the format is correct for both stores and builders whilst allowing ssh-ng where possible. Fixes this error when a remote build is started, though I don't see why it was constructed this way to begin with: ``` error: invalid URL authority: 'ssh//build@sloe': leftover ``` Signed-off-by: PlumJam <git@plumj.am>
Fixes this error when a remote build is started: ``` error: Could not find executable 'ssh' ``` Signed-off-by: PlumJam <git@plumj.am>
plumj-am
force-pushed
the
patch/PlumJam-pznvzykzntlo
branch
from
dc72aa1 to
ab793b3
Compare
Member
|
I'm currently working on a rather large refactor that changes how Circus handles remote builds, so this is a bit obsolete. Or rather, it will be when the refactor is done. I'm drafting this for now so that it doesn't get merged accidentally; you can decide what you want to do after the refactor PR is up or/and merged. |
Contributor
Author
|
Ok, sounds good. Tag me when you open the PR if you remember :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the ssh string is correct for both stores and builders which fixes this error when starting a remote build. Also, we now allow
ssh-ng://URIs but it is stripped for ssh commands.openssh package added to the NixOS module to fix this error: