Skip to content

Add GitHub issue orchestration standard - #16

Merged
maniczko merged 1 commit into
mainfrom
codex/issue-3-apply-github-issue-orchestration-standard-to-rss
May 25, 2026
Merged

Add GitHub issue orchestration standard#16
maniczko merged 1 commit into
mainfrom
codex/issue-3-apply-github-issue-orchestration-standard-to-rss

Conversation

@maniczko

Copy link
Copy Markdown
Owner

Summary

  • Add the RSSmaster GitHub Issue orchestration contract.
  • Add agent task issue template, PR evidence template, and .codex/orchestration.json.
  • Add the repo-local AGENTS.md orchestration section without changing product logic.

Linked Issue

Closes #3

Evidence

  • python C:\Users\user\.codex\skills\github-issue-orchestrator\scripts\codex_orchestrate.py doctor --repo-root . passed.
  • npm run test:unit passed.
  • Required gate labels satisfied: area:governance, gate:quick.

Agent Checklist

  • One issue, one branch, one PR.
  • No direct commit to main.
  • No secrets, tokens, raw emails, or private documents in logs/comments.
  • Residual risks stated.

Risks / Rollback

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request establishes a structured orchestration framework for AI agents by introducing a JSON configuration for gate commands, standardized issue and pull request templates, and updated documentation for the GitHub issue workflow. The reviewer identified a verification gap in the gate:quick command, which lacked backend test execution, and suggested simplifying redundant gate commands by utilizing aggregate scripts for better maintainability.

Comment thread .codex/orchestration.json
Comment on lines +15 to +20
"gate:quick": "npm run build && npm run test:unit:web",
"gate:quality-critical": "npm run build && npm run test:unit && python scripts/check_api.py",
"gate:browser": "npm run check:layout",
"gate:runtime": "npm run health",
"gate:release": "npm run check && npm run health",
"gate:corpus": "npm run check && python scripts/check_api.py"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The gate_commands configuration contains redundancies and a verification gap for backend-related areas:

  1. Backend Verification Gap: gate:quick is mapped to area:backend, area:data, and area:governance (lines 9-12), but it currently only runs web tests (test:unit:web). It should include npm run test:unit:api to ensure backend changes are actually verified in the fast loop.
  2. Redundancy in gate:quality-critical: This command manually duplicates the logic of npm run check (which already includes build, test:unit, and check:contract). Using the aggregate script is more maintainable.
  3. Redundancy in gate:corpus: This command runs python scripts/check_api.py twice (once via npm run check and once explicitly).

Simplifying these to use the aggregate scripts defined in package.json improves clarity and ensures all areas are correctly tested.

Suggested change
"gate:quick": "npm run build && npm run test:unit:web",
"gate:quality-critical": "npm run build && npm run test:unit && python scripts/check_api.py",
"gate:browser": "npm run check:layout",
"gate:runtime": "npm run health",
"gate:release": "npm run check && npm run health",
"gate:corpus": "npm run check && python scripts/check_api.py"
"gate:quick": "npm run build && npm run test:unit:web && npm run test:unit:api",
"gate:quality-critical": "npm run check",
"gate:browser": "npm run check:layout",
"gate:runtime": "npm run health",
"gate:release": "npm run check && npm run health",
"gate:corpus": "npm run check"

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ca3c1f0b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/orchestration.json
Comment on lines +9 to +10
"area:backend": ["gate:quick"],
"area:data": ["gate:quick"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require API checks for backend/data issue areas

area:backend and area:data are mapped only to gate:quick, but gate:quick runs npm run build && npm run test:unit:web (line 15), which does not execute the API verification commands required for FastAPI/repository changes (python scripts/test_api_unit.py and python scripts/check_api.py per docs/quality-gates.md). In practice, any autopilot issue labeled backend/data can pass with only web checks, allowing backend regressions to be merged without contract or API coverage.

Useful? React with 👍 / 👎.

@maniczko
maniczko merged commit a83e737 into main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply GitHub Issue orchestration standard to RSSmaster

1 participant