Skip to content

Polish source onboarding hierarchy - #20

Merged
maniczko merged 1 commit into
mainfrom
codex/issue-8-source-onboarding-hierarchy
May 25, 2026
Merged

Polish source onboarding hierarchy#20
maniczko merged 1 commit into
mainfrom
codex/issue-8-source-onboarding-hierarchy

Conversation

@maniczko

Copy link
Copy Markdown
Owner

Summary

  • Reorders /sources onboarding so the primary add-source form is first in DOM and visual hierarchy.
  • Converts the source onboarding layout into a main-first two-column grid with a quieter right rail for modes and status.
  • Fixes rail button/card clipping and documents the source onboarding hierarchy in docs/ui-system.md.

Evidence

  • npm run build passed.
  • npm run test:unit passed.
  • RSSMASTER_PLAYWRIGHT_MODULE=C:\Users\user\Desktop\RSSmaster\output\playwright-runtime\node_modules\playwright npm run check:sources passed after final CSS changes.
  • RSSMASTER_PLAYWRIGHT_MODULE=C:\Users\user\Desktop\RSSmaster\output\playwright-runtime\node_modules\playwright npm run check:layout passed after final CSS changes.
  • Screenshot evidence inspected: output/playwright/page-audit-sources-desktop-1180.png, output/playwright/page-audit-sources-tablet-1024.png, output/playwright/page-audit-sources-mobile-390.png.

UX Scorecard

  • Overall: 9/10.
  • Hard stops found: none after final pass.
  • Residual risk: manual screen-reader signoff was not performed; automated keyboard/focus smoke passed.

Closes #8

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the workspace sources section by moving the navigation component and implementing a CSS Grid-based layout with named areas for better structure and accessibility. Documentation was also added to define the onboarding hierarchy. Review feedback suggests synchronizing rail widths across stylesheets for consistency, utilizing theme variables instead of hardcoded colors, and removing redundant CSS properties from non-grid containers.


.source-follow-layout {
gap: var(--space-4);
grid-template-columns: minmax(0, 1fr) minmax(230px, 270px);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The rail width defined here (minmax(230px, 270px)) is inconsistent with the definition in apps/web/app/styles/sources.css (minmax(220px, 260px)). Unless this 10px difference is intentional for the premium layout, these values should be synchronized to ensure a consistent user experience across different layout modes. Consider using a shared CSS variable for the rail width.

grid-area: main;
gap: var(--space-4);
padding: clamp(var(--space-4), 1.4vw, var(--space-6));
border-color: rgba(31, 95, 189, 0.16);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This hardcoded RGBA value uses the same base color as the --accent variable (#1f5fbd). To improve maintainability and ensure theme consistency, it is better to use the variable with a color-mix function.

Suggested change
border-color: rgba(31, 95, 189, 0.16);
border-color: color-mix(in srgb, var(--accent), transparent 84%);

Comment on lines +1038 to +1041
.source-follow-aside {
grid-area: aside;
grid-template-columns: 1fr;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The grid-template-columns property is only effective on elements with display: grid. Since .source-follow-aside is a grid item but not a grid container itself, this property is redundant and can be removed to keep the stylesheet clean.

.source-follow-aside {
  grid-area: aside;
}

@maniczko
maniczko merged commit 257a131 into main May 25, 2026
1 check passed
@maniczko
maniczko deleted the codex/issue-8-source-onboarding-hierarchy branch May 25, 2026 12:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb81835a64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1038 to +1040
.source-follow-aside {
grid-area: aside;
grid-template-columns: 1fr;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset aside column span for new sources grid

The new two-column mapping sets .source-follow-aside to grid-area: aside, but it never clears the existing responsive override in apps/web/app/styles/responsive.css (@media (max-width: 1360px) sets grid-column: 1 / -1). As a result, at widths between 1181px and 1360px the aside still spans both columns, so the status rail drops below the main/nav area instead of staying in the right rail intended by this change. Add an explicit reset (for example grid-column: auto) in the new layout rules to avoid inheriting the legacy span behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1-UI-003] Source onboarding hierarchy pass

1 participant