chore(second-shift): consent doc points at lockfile instead of rendering a versions table#96
Merged
Merged
Conversation
…ing a versions table
The rendered | plugin | version | table is a second copy of the lockfile's
plugins map — it drifts on every release and forces version bumps to touch
the consent doc in every consumer repo. The template now names the enabled
plugins ({{PLUGIN_LIST}}) and defers versions to second-shift.lock.json,
which doctor already verifies.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…list The design-toolkit section predates v2.4.0's figma-iterate; regenerated consumer docs already list it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…te change Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 17, 2026
manoldonev
added a commit
that referenced
this pull request
Jul 17, 2026
* docs(dev-pipeline): plan for #95 * chore(review-toolkit): tool-discipline contract + availability-conditional search wording Add a Tool Discipline section to reviewer-baseline (availability-conditional Grep/Glob/Read preference, sanctioned batched Bash, substitution-into-variable ban scoped to locating/reading files, four-part sanction list) and de-model the test-coverage grounding bullet's wc -l to Read. Fix review-lead-synth: tools: Read and the plugin-shipped review-lead source-of-record path. Availability-conditional wording on codebase-explorer's search step. Reconcile the plan's file list. For #95 (AC-1, AC-2, AC-3, AC-4 partial). * chore(design-toolkit): availability-conditional search wording Add availability-conditional wording to the Grep/Glob search lines in figma-faithful-reviewer (3) and figma-faithful-spec-reviewer (1); the sanctioned BASE=$(jq …) base-branch config idioms are left byte-unchanged. For #95 (AC-4). * chore(dev-pipeline): ship tool-discipline measurement probe New tool-discipline-probe.mjs mirrors stall-probe.mjs: dispatches shell-touching reviewers under one selected instruction arm (baseline | grep-nudge | strict-one-command) over a shell-heavy diff, capturing StructuredOutput deaths. Header documents the measured three-arm baseline (~71% compound; grep-nudge null; strict-one-command 3/6 turn-cap deaths) so future proposals are A/B'd, not asserted. For #95 (AC-5). * chore: version bumps + CHANGELOG for #95 review-toolkit 2.1.3 → 2.1.4, design-toolkit 2.1.0 → 2.1.1, dev-pipeline 2.2.6 → 2.2.7; '(in progress)' CHANGELOG entries per changed plugin. For #95 (AC-7). * chore(design-toolkit): availability-conditional wording on figma-faithful skill Grep line Stage-8 scope-completeness gate surfaced an AC-4 coverage gap: figma-faithful/SKILL.md:269 had an unqualified imperative Grep (the 'already tamed' reuse step). AC-4 covers *every* Grep/Glob body line, not just agents/, so this is in scope. Reconcile plan + CHANGELOG. For #95 (AC-4). * chore: reconcile CHANGELOG (in progress) section with #96 #96 merged ahead, adding a second-shift 1.4.1->1.4.2 entry to the same (in progress) section. Fold it in so this branch's CHANGELOG is the correct union of both; the merge resolves take-ours (superset). Versions unaffected — #96 bumped only second-shift, which this PR does not touch. For #95. --------- Co-authored-by: cadenza-dev-pipeline[bot] <272027008+cadenza-dev-pipeline[bot]@users.noreply.github.com> Co-authored-by: Manol Donev <manol.donev@officernd.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onboard-generated
SECOND-SHIFT.mdrendered a| plugin | version |table from the lockfile'spluginsmap — a second copy that drifts on every release and makes version bumps touch the consent doc in every consumer repo (4+ files per bump across a BE/FE pair).templates/consumer/SECOND-SHIFT.md:{{PLUGIN_VERSIONS_TABLE}}→ a one-sentence pointer to.claude/second-shift.lock.jsonwith a{{PLUGIN_LIST}}placeholder (names only, for consent readability).onboard/SKILL.md: rendering instruction updated to match, with the why inline.figma-iterate— added.doctor.shonly references the doc in a warning string (inventory pointer) — nothing parses the table, so no behavior change. The e-commerce / e-commerce-ui consumer docs were already hand-migrated to this exact shape on theirmdonev/second-shift-v2branches.🤖 Generated with Claude Code