Tests/inc coverage#13
Conversation
…s/inc-coverage * 'main' of github.com:rm-hull/postcode-polygons: Add tests on file_operations (#10)
…s/inc-coverage * 'main' of github.com:rm-hull/postcode-polygons: Add tests on CSV parser (#11)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…s/inc-coverage * 'main' of github.com:rm-hull/postcode-polygons: Add tests on codepoint spatial index (#12)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rm-hull, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves the test coverage for the routes package by introducing a new test file. It focuses on validating the behavior of the CodePointSearch and PolygonSearch handlers under various input conditions, as well as thoroughly testing the utility functions responsible for parsing and validating bounding box parameters.
Highlights
- New Test File: A new test file,
routes/search_test.go, has been introduced to enhance test coverage for the application's routing logic. - Route Handler Testing: Comprehensive tests have been added for the
CodePointSearchandPolygonSearchhandlers, covering various scenarios including invalid bounding box formats, excessively large bounding boxes, and successful search operations. - Utility Function Testing: Dedicated unit tests are now in place for the
parseBBoxandisTooBighelper functions, ensuring the robustness of bounding box parsing and validation logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Pull Request Test Coverage Report for Build 15948602289Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
/gemini review |
| testCases := []struct { | ||
| name string | ||
| bboxStr string | ||
| expectErr bool | ||
| }{ | ||
| {name: "valid", bboxStr: "1,2,3,4", expectErr: false}, | ||
| {name: "too few parts", bboxStr: "1,2,3", expectErr: true}, | ||
| {name: "not numbers", bboxStr: "a,b,c,d", expectErr: true}, | ||
| {name: "min greater than max", bboxStr: "4,3,2,1", expectErr: true}, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| _, err := parseBBox(tc.bboxStr) | ||
| if tc.expectErr { | ||
| require.Error(t, err) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
When testing error cases, it's a good practice to assert not just that an error occurred, but also that the error is the one you expect. This makes tests more robust against future changes. I suggest updating the test cases to include the expected error message content and asserting it in the test.
testCases := []struct {
name string
bboxStr string
expectErr bool
errContains string
}{
{name: "valid", bboxStr: "1,2,3,4", expectErr: false},
{name: "too few parts", bboxStr: "1,2,3", expectErr: true, errContains: "bbox must have 4 comma-separated values"},
{name: "not numbers", bboxStr: "a,b,c,d", expectErr: true, errContains: "invalid bbox value"},
{name: "min greater than max", bboxStr: "4,3,2,1", expectErr: true, errContains: "invalid bbox: min values must be less than or equal to max values"},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
_, err := parseBBox(tc.bboxStr)
if tc.expectErr {
require.Error(t, err)
if tc.errContains != "" {
require.Contains(t, err.Error(), tc.errContains)
}
} else {
require.NoError(t, err)
}
})
}
…s/inc-coverage * 'main' of github.com:rm-hull/postcode-polygons: Add tests over search endpoints (#13)
2 participants
No description provided.