Skip to content

Promote Search SDK as a replacement of Geocoder#1342

Merged
friendoye merged 2 commits into
mainfrom
nn/geocoder-add-deprecation-note
Dec 8, 2021
Merged

Promote Search SDK as a replacement of Geocoder#1342
friendoye merged 2 commits into
mainfrom
nn/geocoder-add-deprecation-note

Conversation

@friendoye

Copy link
Copy Markdown
Contributor

Search SDK for Android now is the recommended way to access Geocoding API on Android platform.
To promote Search SDK usage this PR:

  1. Adds Geocoder deprecation note;
  2. Assigns services-geocoding ownership to @mapbox/search-sdk-android team

@friendoye
friendoye requested a review from LukasPaczos December 6, 2021 15:28

@LukasPaczos LukasPaczos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are recommending the switch, should we also deprecate the classes in this project and point to the Search SDK?

@friendoye

Copy link
Copy Markdown
Contributor Author

@LukasPaczos I wouldn't mind adding deprecation notes and annotation to Geocoder's classes, but I'm not fully convinced it's necessary:

  1. Search SDK is available only for Android platform, while Java SDK's artifacts are available for JVM as well. Customers using Geocoder on JVM will not be able to migrate to Search SDK, making deprecation notes a bit misleading;
  2. Search SDK doesn't have plans to support batch geocoding right now, but Geocoder provides such functionality (migration guide emphasises this fact). Thus we can only deprecate a few methods of MapboxGeocoding class.

@LukasPaczos

Copy link
Copy Markdown
Contributor

Thanks, that makes total sense 👍

@friendoye
friendoye merged commit 16139be into main Dec 8, 2021
@friendoye
friendoye deleted the nn/geocoder-add-deprecation-note branch December 8, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants