Skip to content

Traffic tendencies#1451

Merged
vadzim-vys merged 10 commits into
mainfrom
vv-traffic-tendecies
Jun 14, 2022
Merged

Traffic tendencies#1451
vadzim-vys merged 10 commits into
mainfrom
vv-traffic-tendecies

Conversation

@vadzim-vys

Copy link
Copy Markdown
Contributor

This PR introduces traffic tendencies annotations

@vadzim-vys
vadzim-vys requested a review from a team as a code owner June 14, 2022 12:16
@codecov

codecov Bot commented Jun 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1451 (268c0ed) into main (a15e481) will not change coverage.
The diff coverage is n/a.

❗ Current head 268c0ed differs from pull request most recent head c3815aa. Consider uploading reports for the commit c3815aa to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1451   +/-   ##
=========================================
  Coverage     75.67%   75.67%           
  Complexity      881      881           
=========================================
  Files           125      125           
  Lines          3906     3906           
  Branches        578      578           
=========================================
  Hits           2956     2956           
  Misses          687      687           
  Partials        263      263           
Impacted Files Coverage Δ
...mapbox/api/directions/v5/models/LegAnnotation.java 100.00% <ø> (ø)
.../mapbox/api/directions/v5/models/RouteOptions.java 85.86% <ø> (ø)

@RingerJK RingerJK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extend DirectionsRefreshResponseTest and DirectionsRouteRefreshTest for traffic_tendency

@vadzim-vys

Copy link
Copy Markdown
Contributor Author

please extend DirectionsRefreshResponseTest and DirectionsRouteRefreshTest for traffic_tendency

Added traffic tendency data to the mentioned tests. Personally I don't see much value in it but I'm happy to increase teammates' confidence in our tests. But TBH I not sure, maybe now I feel more confident in our tests too 🤔 🙂

Comment thread samples/src/main/java/com/mapbox/samples/BasicDirectionsRefresh.java Outdated
@vadzim-vys
vadzim-vys requested a review from RingerJK June 14, 2022 16:04

@RingerJK RingerJK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vadzim-vys
vadzim-vys merged commit 4c0fe94 into main Jun 14, 2022
@vadzim-vys
vadzim-vys deleted the vv-traffic-tendecies branch June 14, 2022 16:36
@LukasPaczos

Copy link
Copy Markdown
Contributor

Just about too late :(

This PR will have to be reverted because we should not expose the bindings for this feature.

vadzim-vys added a commit that referenced this pull request Jun 15, 2022
vadzim-vys added a commit that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants