Added fromjson test and method for carmen feature - #279
Merged
Conversation
zugaldia
requested changes
Jan 17, 2017
| * @since 2.0.0 | ||
| */ | ||
| public static CarmenFeature fromJson(String json) { | ||
| GsonBuilder gson = new GsonBuilder(); |
Member
There was a problem hiding this comment.
@cammace Don't you need to attach our custom deserializer here gson.registerTypeAdapter(Position.class, new PositionDeserializer());?
Author
There was a problem hiding this comment.
Good point, need to make my test more robust to catch this also.
zugaldia
approved these changes
Jan 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #278
Carmen Feature was using the
fromJson()method found in the Feature.class. This method was returning a Feature object and not a Carmen. To get around this, I added a fromJson method to Carmen Feature.