changed compile into implemenation#737
Merged
Merged
Conversation
osana
force-pushed
the
osana-dependencies-717
branch
from
March 6, 2018 14:45
daf6609 to
3eaf98c
Compare
Member
|
A little bit of context around this. With the newer gradle version the old
The former doesn't expose dependencies to the consumer apps while the api does. For most cases we actually want to expose the dependencies and we should rely on api for that. For dependencies as support android versions we actually rather not expose them if not needed. More context in https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations. |
Merged
osana
force-pushed
the
osana-dependencies-717
branch
2 times, most recently
from
March 14, 2018 00:17
62f9eed to
32dfe9a
Compare
cammace
reviewed
Mar 14, 2018
| implementation project(":services-matching") | ||
| implementation project(":services-staticmap") | ||
|
|
||
| implementation dependenciesList.retrofit |
There was a problem hiding this comment.
Why is this needed for the sample project, doesn't one of our service libraries carry retrofit over?
Contributor
Author
osana
force-pushed
the
osana-dependencies-717
branch
from
March 14, 2018 14:20
32dfe9a to
2d7b5c7
Compare
cammace
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #717