remove unprintable chars#747
Merged
Merged
Conversation
Contributor
Author
|
@danesfeder it would be great if you could test this on the phone that had this issue |
cammace
reviewed
Mar 13, 2018
| if (TextUtils.isEmpty(osName) || TextUtils.isEmpty(osVersion) || TextUtils.isEmpty(osArch)) { | ||
| return Constants.HEADER_USER_AGENT; | ||
| } else { | ||
| final String onlyPrintableChars = "\\P{Print}"; |
There was a problem hiding this comment.
Is this a Regex? can we make it a constant?
|
Any chance we could add a test to ensure the issues been resolved? |
osana
force-pushed
the
osana-header-nonascii
branch
9 times, most recently
from
March 14, 2018 00:05
9f85d47 to
0af00ec
Compare
osana
force-pushed
the
osana-header-nonascii
branch
from
March 14, 2018 00:15
0af00ec to
c865220
Compare
Contributor
Author
|
@cammace changed the test to compare string to make sure non ascii codes are removed. |
cammace
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #720