Skip to content

#669: try to fix black screen on emulator#671

Merged
kiryldz merged 1 commit intomainfrom
669-fix-emulator-black-screen
Sep 24, 2021
Merged

#669: try to fix black screen on emulator#671
kiryldz merged 1 commit intomainfrom
669-fix-emulator-black-screen

Conversation

@zeac
Copy link
Copy Markdown
Contributor

@zeac zeac commented Sep 24, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #669

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Fix black screen when resuming activity with MapView on x86 emulator, Android API <= 23.</changelog>.

Summary of changes

Explicitly set no context when releasing EGL surface.
Tests could not be written as pixel-match tests required here.

User impact (optional)

@zeac zeac requested a review from kiryldz September 24, 2021 09:29
Comment thread sdk/src/main/java/com/mapbox/maps/renderer/egl/EGLCore.kt Outdated
@zeac zeac force-pushed the 669-fix-emulator-black-screen branch from e3a76a6 to 89c290a Compare September 24, 2021 09:57
Copy link
Copy Markdown
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for looking into it!
Sadly enough pixel match tests are not in place yet so can't add a test to verify it cc @alexander-kulikovskii

@kiryldz kiryldz added the bug 🪲 Something isn't working label Sep 24, 2021
@kiryldz kiryldz merged commit 214d1e7 into main Sep 24, 2021
@kiryldz kiryldz deleted the 669-fix-emulator-black-screen branch September 24, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Black screen when restoring surface on x86, Android SDK 23

5 participants