#669: try to fix black screen on emulator#671
Merged
Conversation
kiryldz
reviewed
Sep 24, 2021
e3a76a6 to
89c290a
Compare
kiryldz
approved these changes
Sep 24, 2021
Contributor
kiryldz
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for looking into it!
Sadly enough pixel match tests are not in place yet so can't add a test to verify it cc @alexander-kulikovskii
pengdev
approved these changes
Sep 24, 2021
alexander-kulikovskii
approved these changes
Sep 24, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #669
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Fix black screen when resuming activity with MapView on x86 emulator, Android API <= 23.</changelog>.Summary of changes
Explicitly set no context when releasing EGL surface.
Tests could not be written as pixel-match tests required here.
User impact (optional)