Skip to content

Move EGL no current context to surface creation#691

Merged
kiryldz merged 2 commits intomainfrom
kdz-fix-make-no-context
Sep 29, 2021
Merged

Move EGL no current context to surface creation#691
kiryldz merged 2 commits intomainfrom
kdz-fix-make-no-context

Conversation

@kiryldz
Copy link
Copy Markdown
Contributor

@kiryldz kiryldz commented Sep 29, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.

Summary of changes

Revisiting fix introduced in #671.
Moved explicit setting EGL10.NO_CONTEXT from surface destroy to surface creation as surface destroy may be followed up by complete render thread destruction and in this case we still need valid EGL context to perform cleanup of GPU buffers / textures.

User impact (optional)

@kiryldz kiryldz requested review from a team and zeac September 29, 2021 09:37
@kiryldz kiryldz self-assigned this Sep 29, 2021
@kiryldz kiryldz merged commit 46f97f6 into main Sep 29, 2021
@kiryldz kiryldz deleted the kdz-fix-make-no-context branch September 29, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants