Excluding Tolls not working as expected

[sridharvenkatesan]

I have tried the following code to exclude toll gates. But it is always showing the route with tolls.

NavigationRoute.builder(NavigationMapRouteActivity.this) .accessToken(Mapbox.getAccessToken()) .origin(origin) .alternatives(true) .exclude(DirectionsCriteria.EXCLUDE_TOLL) .destination(destination) .build()

Alternatives also seems not working good. I can't see more than one route in my screen. I thought giving alternatives true will show one or more routes. But it is always showing only one route.

ANDROID API : 24-25
SDK VERSION : 0.41.0

Steps to trigger behavior

1. Initially don't add the exclude and alternatives to NavigationRoute and check the route
2. Add the exclude toll and check the route
3. Now add the alternative true and check the route

Expected behavior

It should not show the route with toll gates and it should provide one or two different routes to the user.

Actual behavior

It is always showing the same route.

[Guardiola31337]

Hey @sridharvenkatesan 👋 thanks for reaching out and report your issue.

I've just tested adding a .exclude(DirectionsCriteria.EXCLUDE_TOLL) to the NavigationLauncherActivity from the test app (which also uses .alternatives(true))

mapbox-navigation-android/app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/navigationui/NavigationLauncherActivity.java

Lines 255 to 259 in f2a082c

	NavigationRoute.Builder builder = NavigationRoute.builder(this)
	.accessToken(Mapbox.getAccessToken())
	.origin(currentLocation)
	.profile(getRouteProfileFromSharedPreferences())
	.alternatives(true);

and it's working fine 👀

Routes from Washington to Philadelphia - tolls not excluded

Routes from Washington to Philadelphia - tolls excluded

Wondering if it's a data problem. Could you share the origin and destination? That'll give us better insight into your concrete use case and what could be causing your problem.

Thanks in advance.

[sridharvenkatesan]

Hi @Guardiola31337. Thanks for your reply. I have tried this sample app and it is working fine. But when I tried to initialize NavigationMapboxMap, I am getting following error.

2019-08-23 17:47:16.599 22819-22819/app.abcourier.ccmobile E/Mbgl-MapChangeReceiver: Exception in onDidFinishLoadingStyle
android.content.res.Resources$NotFoundException: Resource ID #0x0
at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:190)
at android.content.res.Resources.getDrawable(Resources.java:770)
at android.content.Context.getDrawable(Context.java:525)
at android.support.v4.content.ContextCompat.getDrawable(ContextCompat.java:463)
at com.mapbox.services.android.navigation.ui.v5.ThemeSwitcher.retrieveThemeMapMarker(ThemeSwitcher.java:50)
at com.mapbox.services.android.navigation.ui.v5.map.NavigationMapboxMap.initializeNavigationSymbolManager(NavigationMapboxMap.java:638)
at com.mapbox.services.android.navigation.ui.v5.map.NavigationMapboxMap.(NavigationMapboxMap.java:96)
at app.abcourier.ccmobile.activity.mapbox.MapBoxActivity$3.onStyleLoaded(MapBoxActivity.java:211)

This is the line where I am getting an error.

navigationMapboxMap = new NavigationMapboxMap(mapView, mapboxMap);

@Override
    public void onMapReady(@NonNull final MapboxMap mapboxMap) {
        this.mapboxMap = mapboxMap;
        mapboxMap.setStyle(getString(R.string.navigation_guidance_day), new Style.OnStyleLoaded() {
            @Override
            public void onStyleLoaded(@NonNull Style style) {
                navigationMapboxMap = new NavigationMapboxMap(mapView, mapboxMap);
                navigationMapboxMap.setOnRouteSelectionChangeListener(MapBoxActivity.this);
                navigationMapboxMap.updateLocationLayerRenderMode(RenderMode.COMPASS);
         }
        });
    }

This is the method I am getting error in NavigationMapboxMap.

private void initializeNavigationSymbolManager(MapView mapView, MapboxMap mapboxMap) { Bitmap markerBitmap = ThemeSwitcher.retrieveThemeMapMarker(mapView.getContext()); mapboxMap.getStyle().addImage(MAPBOX_NAVIGATION_MARKER_NAME, markerBitmap); SymbolManager symbolManager = new SymbolManager(mapView, mapboxMap, mapboxMap.getStyle()); navigationSymbolManager = new NavigationSymbolManager(symbolManager); SymbolOnStyleLoadedListener onStyleLoadedListener = new SymbolOnStyleLoadedListener(mapboxMap, markerBitmap); mapView.addOnDidFinishLoadingStyleListener(onStyleLoadedListener); }

Please give me your inputs.

[sridharvenkatesan]

Hi Team,

We have issues with toll roads. In our code, we are excluding toll roads.

NavigationRoute.builder(NavigationMapRouteActivity.this)
.accessToken(Mapbox.getAccessToken())
.origin(origin)
.alternatives(true)
.profile(getRouteProfileFromSharedPreferences())
.exclude(DirectionsCriteria.EXCLUDE_TOLL)
.destination(destination)
.build()
This is working fine in most of the cases. But, In some cases, ReRoute callback methods are calling while we navigating.
Once the ReRoute callback methods are called then the exclude becomes null.
I have tried printing this log information in onProgressChange.
Log.e("Route-Progress-Exclude", routeProgress.directionsRoute().routeOptions().exclude() + "");
Whenever the ReRoute callback methods are called, the log is showing null.

I have tried with latest version 0.42.4 and still we are facing this issue.

I have found the coordinates to reproduce this issue.

1. Origin Coordinates 43.65423202---79.70544455 and Destination Coordinates 43.650728574511----79.7040401920922, ReRoute Coordinates 43.65438938----79.70524079.

2. Origin 43.76933621, 79.46783238,Destination--43.7599155339893, 79.5108612818684,Reroute 43.76873826, 79.46770264

Please check it and let me know the solution for this issue.

[sridharvenkatesan]

Hi @Guardiola31337 ,

Any updates regarding this issue?

[EricGeiler]

map-toll-routing-issue01.txt
map-toll-routing-issue02.txt

Adding log files to speed up this ticket review and resolution. For such an important issue I'm very surprised this is taking so long to resolve.

[danpat]

@EricGeiler @sridharvenkatesan Reading between the lines of all the above, can the issue be summarized as "exclude=toll works for initial routing, but is not being carried through to reroute callbacks?"

cc @Guardiola31337

[EricGeiler]

Yes that is 100% correct based on what our developer has been telling me, and the feedback from drivers on the road.. I have also witnessed it personally on my device.. exclude=tolls works for the initial routing, but if drivers take a diff turn or system calcs a re-route, then the re-route does NOT exclude tolls like we expect it to. I have verified the OSM data for the tolls roads in question, onramps and expressway have valid flags set for tolls as per OSM or JOSM checks I did. [cid:image003.jpg@01D5ED59.85A59030] From: Daniel Patterson <notifications@github.com> Sent: Thursday, February 27, 2020 10:29 AM To: mapbox/mapbox-navigation-android <mapbox-navigation-android@noreply.github.com> Cc: Eric Geiler <eric.geiler@abcourier.com>; Mention <mention@noreply.github.com> Subject: Re: [mapbox/mapbox-navigation-android] Excluding Tolls not working as expected (#2026) @EricGeiler<https://github.com/EricGeiler> @sridharvenkatesan<https://github.com/sridharvenkatesan> Reading between the lines of all the above, can the issue be summarized as "exclude=toll works for initial routing, but is not being carried through to reroute callbacks?" cc @Guardiola31337<https://github.com/Guardiola31337> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2026?email_source=notifications&email_token=AOVS42UHIH46M6RHSXEZTW3RE7L5FA5CNFSM4ILUHTLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENEYGFY#issuecomment-592020247>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOVS42V3JKRFPDQE33JUOH3RE7L5FANCNFSM4ILUHTLA>.

[ericaeckes]

@zugaldia @danpat Any update here? Issues are worsening for the customer.

[zugaldia]

@ericaeckes it's on the team's board for investigation this sprint. We'll provide an update here as soon as we know more.