add notification interceptor for android auto#5778
Merged
Zayankovsky merged 1 commit intomainfrom May 17, 2022
Merged
Conversation
Zayankovsky
commented
May 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #5778 +/- ##
============================================
- Coverage 67.63% 67.06% -0.57%
+ Complexity 3829 3790 -39
============================================
Files 586 584 -2
Lines 23583 23604 +21
Branches 2715 2710 -5
============================================
- Hits 15951 15831 -120
- Misses 6614 6767 +153
+ Partials 1018 1006 -12
|
kmadsen
reviewed
May 5, 2022
7f9ca2e to
12ad33c
Compare
2072a8a to
1f1d700
Compare
kmadsen
reviewed
May 16, 2022
kmadsen
reviewed
May 16, 2022
kmadsen
reviewed
May 16, 2022
Contributor
|
Thanks for picking this up! It works great, especially like how it shows the upcoming maneuver while navigating. It also serves as great example of how you can build your own car notification with Also, thanks for adding |
kmadsen
approved these changes
May 16, 2022
kmadsen
reviewed
May 16, 2022
3a1cfe9 to
5505c7b
Compare
5505c7b to
eaa81e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a notification interceptor, that lets easily set up notifications in Android Auto. Not sure about adding a dependency on
:libtrip-notificationmodule, but needed a way to re-use notification resources somehow.Screenshots or Gifs
There is also an option to show a heads-up notification by setting high importance, but since the notification is updated approximately every two seconds this option should be used only when there is a significant change in the route progress. This and any other extra customization can be applied via
CarNotificationInterceptorarguments if needed.