move notification resources to base module#5803
Merged
Zayankovsky merged 1 commit intomainfrom May 13, 2022
Merged
Conversation
Zayankovsky
force-pushed
the
vz-move-resources
branch
from
9966a7d to
899e0b2
Compare
Codecov Report
@@ Coverage Diff @@
## main #5803 +/- ##
============================================
+ Coverage 67.22% 67.72% +0.49%
- Complexity 3799 3812 +13
============================================
Files 585 585
Lines 23627 23627
Branches 2708 2708
============================================
+ Hits 15883 16001 +118
+ Misses 6738 6610 -128
- Partials 1006 1016 +10
|
Zayankovsky
force-pushed
the
vz-move-resources
branch
from
899e0b2 to
f389c10
Compare
kmadsen
reviewed
May 12, 2022
| import com.mapbox.navigation.base.maneuver.model.BaseTurnIconResources | ||
| import com.mapbox.navigation.trip.notification.R | ||
|
|
||
| class NotificationTurnIconResources private constructor( |
Contributor
There was a problem hiding this comment.
Maybe we should expose a resource api similar to MapboxLaneIconsApi
We did this for android auto as well #4729
Contributor
Author
There was a problem hiding this comment.
TurnIconHelper looks like such an API. We can think of making it public.
LukasPaczos
approved these changes
May 13, 2022
Contributor
|
@Zayankovsky I think we missed to update the transifex and reflect that the strings were moved to a different path. Could you take care of that? /cc @kmadsen @LukasPaczos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved notification resources to
:libnavigation-base, which is necessary for implementing a notification interceptor in Android Auto (#5778). Also it might be useful for those, who would like to implement their customTripNotification.