Skip to content

convert android auto road label to a bitmap widget#6541

Merged
Zayankovsky merged 1 commit intomainfrom
vz-NAVAND-335
Nov 4, 2022
Merged

convert android auto road label to a bitmap widget#6541
Zayankovsky merged 1 commit intomainfrom
vz-NAVAND-335

Conversation

@Zayankovsky
Copy link
Copy Markdown
Contributor

@Zayankovsky Zayankovsky commented Nov 2, 2022 •
edited
Loading

Description

Closes #5794.

@Zayankovsky Zayankovsky added ⚠️ DO NOT MERGE PR should not be merged! Android Auto Bugs, improvements and feature requests on Android Auto. labels Nov 2, 2022
@Zayankovsky Zayankovsky requested a review from a team as a code owner November 2, 2022 12:58
@Zayankovsky Zayankovsky self-assigned this Nov 2, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

Merging #6541 (92fc7a2) into main (92fc7a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 92fc7a2 differs from pull request most recent head 99db5f1. Consider uploading reports for the commit 99db5f1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6541   +/-   ##
=========================================
  Coverage     70.95%   70.95%           
  Complexity     5084     5084           
=========================================
  Files           727      727           
  Lines         28378    28378           
  Branches       3376     3376           
=========================================
  Hits          20136    20136           
  Misses         6972     6972           
  Partials       1270     1270

@kmadsen
Copy link
Copy Markdown
Contributor

kmadsen commented Nov 2, 2022

Thanks for finding and demonstrating this! Any BitmapWidget fix will happen in a 10.10.0 map version, and we're planning on releasing with support for 10.9.0.

We can hold off on removing the surfacelayer approach and this will be a known issue that can be fixed with an upgrade.

@Zayankovsky
Copy link
Copy Markdown
Contributor Author

Zayankovsky commented Nov 2, 2022

Thanks for finding and demonstrating this! Any BitmapWidget fix will happen in a 10.10.0 map version, and we're planning on releasing with support for 10.9.0.

We can hold off on removing the surfacelayer approach and this will be a known issue that can be fixed with an upgrade.

Even if we don't migrate to BitmapWidget the issue still exists, because all other widgets disappear after you remove the road label.

@Zayankovsky Zayankovsky mentioned this pull request Nov 2, 2022
Merged
@Zayankovsky Zayankovsky force-pushed the vz-NAVAND-335 branch 2 times, most recently from 6dcd061 to 629513d Compare November 3, 2022 13:30
@Zayankovsky Zayankovsky added skip changelog Should not be added into version changelog. and removed ⚠️ DO NOT MERGE PR should not be merged! labels Nov 3, 2022
@Zayankovsky Zayankovsky force-pushed the vz-NAVAND-335 branch 2 times, most recently from 970bd86 to 46cb128 Compare November 3, 2022 20:15
kmadsen
kmadsen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kmadsen kmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the CarTextLayouerHost removed in favor of an upstream api! 🎉

@Zayankovsky Zayankovsky removed the skip changelog Should not be added into version changelog. label Nov 3, 2022
@kmadsen
Copy link
Copy Markdown
Contributor

kmadsen commented Nov 3, 2022

Have been testing it on a Xiaomi POCO 3: MIUI Global 13.0.4

looks good

@Zayankovsky Zayankovsky enabled auto-merge (rebase) November 4, 2022 09:25
@Zayankovsky Zayankovsky merged commit 4b86dc6 into main Nov 4, 2022
@Zayankovsky Zayankovsky deleted the vz-NAVAND-335 branch November 4, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kmadsen kmadsen kmadsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Zayankovsky Zayankovsky

Labels

Android Auto Bugs, improvements and feature requests on Android Auto.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android Auto] Integrate maps widgets for current road label

2 participants

@Zayankovsky @kmadsen