Skip to content

do not inherit internal class in public RoadLabelSurfaceLayer#6546

Merged
Zayankovsky merged 2 commits intomainfrom
vz-NAVAND-335-2
Nov 3, 2022
Merged

do not inherit internal class in public RoadLabelSurfaceLayer#6546
Zayankovsky merged 2 commits intomainfrom
vz-NAVAND-335-2

Conversation

@Zayankovsky
Copy link
Copy Markdown
Contributor

@Zayankovsky Zayankovsky commented Nov 2, 2022

Description

Refs #6541 (comment).

@Zayankovsky Zayankovsky added skip changelog Should not be added into version changelog. Android Auto Bugs, improvements and feature requests on Android Auto. labels Nov 2, 2022
@Zayankovsky Zayankovsky self-assigned this Nov 2, 2022
@Zayankovsky Zayankovsky requested a review from a team as a code owner November 2, 2022 20:25
@Zayankovsky Zayankovsky mentioned this pull request Nov 2, 2022
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

Merging #6546 (61a542e) into main (868e038) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6546   +/-   ##
=========================================
  Coverage     70.45%   70.45%           
  Complexity     5020     5020           
=========================================
  Files           729      729           
  Lines         28361    28361           
  Branches       3370     3370           
=========================================
  Hits          19983    19983           
  Misses         7110     7110           
  Partials       1268     1268

@Zayankovsky
Copy link
Copy Markdown
Contributor Author

Zayankovsky commented Nov 3, 2022

This is actually wrong, because RoadLabelSurfaceLayerDelegate.children is not called, therefore road label widget is not drawn.

@Zayankovsky Zayankovsky marked this pull request as draft November 3, 2022 12:50
@Zayankovsky Zayankovsky marked this pull request as ready for review November 3, 2022 17:27
kmadsen
kmadsen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kmadsen kmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better!

@Zayankovsky
Copy link
Copy Markdown
Contributor Author

Zayankovsky commented Nov 3, 2022

This is actually wrong, because RoadLabelSurfaceLayerDelegate.children is not called, therefore road label widget is not drawn.

Looks like the only thing that I missed was to add delegation for onVisibleAreaChanged, because children is only called from onAttached, onDetached and onVisibleAreaChanged.

@Zayankovsky Zayankovsky enabled auto-merge (rebase) November 3, 2022 17:36
@Zayankovsky Zayankovsky merged commit 92fc7a2 into main Nov 3, 2022
@Zayankovsky Zayankovsky deleted the vz-NAVAND-335-2 branch November 3, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kmadsen kmadsen kmadsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Zayankovsky Zayankovsky

Labels

Android Auto Bugs, improvements and feature requests on Android Auto. skip changelog Should not be added into version changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zayankovsky @kmadsen