This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Conversation
added 2 commits
September 8, 2015 21:54
Contributor
Author
|
@sbma44 how does this look to you? Place type filtering is like geocoder.forward(address, place_types=('address', 'poi'))and proximity geocoder.forward(address, lng=0, lat=0)Geocoding support is complete. |
Conflicts: mapbox/scripts/geocoder.py
Member
|
I would suggest changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add place type filtering and proximity biasing.
In the API, these are new keyword arguments to the
forward()andreverse()methods. To side step coordinate order confusion, I've madelngandlatseparate keywords. They can be given in either order.Are results returned sorted by proximity to the given lng, lat? That would be a useful fact to convey to users.
Closes #11
Closes #12