Don't subversion for different releases of OS X #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Seems like copying just |
Contributor
|
One followup we'll want after this becomes standard is to remove the multiple |
jfirebaugh
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Mar 11, 2016
Closed
springmeyer
pushed a commit
to mapnik/mapnik
that referenced
this pull request
Mar 11, 2016
springmeyer
pushed a commit
to mapbox/mapnik-vector-tile
that referenced
this pull request
Mar 11, 2016
Contributor
Author
mason.sh
Outdated
| if [ ${MASON_PLATFORM} = 'osx' ]; then | ||
| export MASON_HOST_ARG="--host=x86_64-apple-darwin" | ||
| export MASON_PLATFORM_VERSION=`xcrun --sdk macosx --show-sdk-version` | ||
| export MASON_PLATFORM_VERSION="all" |
Member
There was a problem hiding this comment.
Can we use x86_64 instead? We're only using all on iOS because we're producing fat binaries for that platform; all other platforms use arch-specific platform versions.
Contributor
Author
There was a problem hiding this comment.
👍, I'll switch to x86_64.
Contributor
Author
There was a problem hiding this comment.
Using x86_64 causes a failure in one of the tests. I'll need someone to help me figure out why https://travis-ci.org/mapbox/mason/jobs/115412535.
jfirebaugh
force-pushed
the
118-no-osx-subversioning
branch
4 times, most recently
from
a26357f to
569f353
Compare
Instead of building for osx-10.10, osx-10.11, etc., build osx-x86_64. Continue to use -mmacosx-version-min=10.8.
jfirebaugh
force-pushed
the
118-no-osx-subversioning
branch
from
4831426 to
8c239e5
Compare
This was referenced Mar 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building for
osx-10.10,osx-10.11, etc., build a singleosx-allversion. Continue to use-mmacosx-version-min=10.8.Fixes #118
Before testing this, I'll need to copy existing
osx-10.10/osx-10.11packages toosx-allon S3. @springmeyer @kkaefer, should I copy one or the other, or both? And if both, should theosx-10.10orosx-10.11package get priority when they both exist?