Add more turn lane configurations #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a lone sharp turn configuration. Added most dual-use configurations, except for some tricky combinations that rarely if ever occur in OpenStreetMap data. Added some common triple-use configurations.
Contributor
Author
|
|
avi-c
approved these changes
Mar 23, 2021
This was referenced Mar 23, 2021
Merged
This was referenced Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the repertoire of supported turn lane configurations.
Added another single-use lane configuration:
Added many dual-use lane configurations:
Added a couple very common triple-use lane configurations:
The remaining configurations are either redundant (since each asset can be flipped based on the
flipHorizontallyparameter) or rare (or nonexistent) in OpenStreetMap.Renamed all the lane assets according to the format “lane ___ not ___ or ___” to reduce confusion. Clients will need to update any code that calls into the StyleKit drawing methods, which have consequently been renamed.
With these changes, there are many more turn lane shapes than there were before. To minimize the number of assets, single-color dual-use icons are no longer included. The “straight or right turn” asset has been deleted. To show a turn lane that should not be taken at all, set the primary and secondary color parameters to the same muted color.
Fixes #8.
/cc @mapbox/mobile-navigation-team @avi-c @d-prukop