Honor byteOffset when constructing the DataView#147
Merged
Conversation
PbfReader and PbfWriter build their DataView over `this.buf.buffer` but read/write fixed-width fields (double/float/fixed32/fixed64) at offsets relative to `this.buf`. When the backing view has a non-zero byteOffset (which Node Buffers from the shared pool routinely do) every fixed-width access lands at the wrong absolute offset and returns garbage. Varint/string reads were unaffected because they index `this.buf` directly. Construct the DataView with the view's byteOffset and byteLength so `this.pos` (a buf-relative offset) resolves correctly. Adds regression tests covering fixed-width read and write through a view with a non-zero byteOffset.
mourner
approved these changes
Jul 1, 2026
mourner
left a comment
mourner
left a comment
Member
There was a problem hiding this comment.
Nice catch, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PbfReader and PbfWriter build their DataView over
this.buf.bufferbut read/write fixed-width fields (double/float/fixed32/fixed64) at offsets relative tothis.buf. When the backing view has a non-zero byteOffset (which Node Buffers from the shared pool routinely do) every fixed-width access lands at the wrong absolute offset and returns garbage (e.g. subnormal doubles). Varint/string reads were unaffected because they indexthis.bufdirectly.Construct the DataView with the view's byteOffset and byteLength so
this.pos(a buf-relative offset) resolves correctly.Adds regression tests covering fixed-width read and write through a view with a non-zero byteOffset.