Add windowSize option for sliding window diff counts#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New opt-in
windowSizeoption. When set to a finiteN,pixelmatchreturns the maximum number of diff pixels in anyN×Nwindow instead of the total count. Omitted orInfinitykeeps current behavior (the total is just the whole-image window).Why: scattered GPU/AA speckle never packs densely into one window, but a genuine regression does. Failing on window density lets a harness run stricter thresholds to catch smaller real changes without tripping over noise.
How: a lazily-allocated diff mask (only when the option is set, so the default path stays allocation-free) plus an O(len) sliding-window sum. Default behavior and perf are unchanged;
windowSize: 32adds ~16% overhead.