fix: guard against None platform in get_exif sequence download#90
Open
chrisdebian wants to merge 1 commit into
Open
fix: guard against None platform in get_exif sequence download#90chrisdebian wants to merge 1 commit into
chrisdebian wants to merge 1 commit into
Conversation
When the Mapilio API returns a sequence whose osv.platform field is
absent, api_data_details.get("osv", {}).get("platform") returns None.
The subsequent `"iPhone" in platform` check raises:
TypeError: argument of type 'NoneType' is not iterable
Add a truthiness guard so the branch is skipped when platform is None.
Fixes mapilio#84
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Mapilio API returns a sequence whose
osv.platformfield is absent,api_data_details.get("osv", {}).get("platform")returnsNone. The subsequent check:raises
TypeError: argument of type 'NoneType' is not iterablebecause theinoperator requires a string on the right-hand side.Fix
Add a truthiness guard so the branch is skipped cleanly when
platformisNone:Test plan
Noneplatform → no exception, device make/model left at defaults"iOS"platform → Apple branch taken as before"iPhone12,1"platform → Apple branch taken via"iPhone" in platform"Android"platform → Android branch taken as beforeCloses #84
🤖 Generated with Claude Code