Skip to content

Remove build warnings#1094

Closed
YanNoun wants to merge 9 commits intomainfrom
clean-build-warnings
Closed

Remove build warnings#1094
YanNoun wants to merge 9 commits intomainfrom
clean-build-warnings

Conversation

@YanNoun
Copy link
Contributor

@YanNoun YanNoun commented May 21, 2025

This PR removes all the annoying build warnings that we had by :

  • Setting CMake policy
  • Add C++ warning ignores in third-party libraries only, since we're very unlikely to touch this code ever again
  • Fix the actual warnings in the rest of OpenSfM code

@facebook-github-bot
Copy link
Contributor

Hi @YanNoun!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@fabianschenk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@fabianschenk merged this pull request in 752e008.

@paulinus paulinus deleted the clean-build-warnings branch November 3, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants