Skip to content

[Release] Package Release Changes #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rubix982 merged 14 commits into from
Aug 20, 2021
Merged

[Release] Package Release Changes #110

Rubix982 merged 14 commits into from
Aug 20, 2021

Conversation

@Rubix982
Copy link
Contributor

@Rubix982 Rubix982 commented Aug 20, 2021 •
edited
Loading

Pull Request Type

  • 🏆 Enhancements - It introduces some changes,
    • Finishes the requirements of making releases of the project
    • Automates the step of pushing to PyPi
    • Restructures to fit the PyPi release
    • Fixed all import issues for the project
    • Tested out locally for virtualenv and on Google Collab as well
    • Improvements to setup.py

On merge, it should close #8 and close #86

Purpose

To allow making releases for the SDK

Feedback required over

  • A quick pair of 👀 on the code
  • Discussion on the technical approach

Mentions

Rubix982 added 14 commits August 19, 2021 09:52
@Rubix982
Moved mapillary to src/mapillary/
fad7e5e 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Revert structure modifications
99a5c36 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Introduced Pipfile dependencies
5d3b916 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Fixed building lib, wheel, egginfo, with setup.py
ff86ef9 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Fixed imports for API Adaptors
b905e26 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Further progress on setup.py, fixed more import problems
b9c0d8b 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Changed path conf, mapillary.py -> interface.py
f546939 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Include MANIFEST, add check-manifest, add extra_requires
1620372 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Moved mapillary to src/mapillary/ again
a293747 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Finalze setup.py
2bd65dd 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Removed OSMNX as dependency
45d2331 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Fixed import issues for new release
85b3733 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Fixed styling command
111caa1 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982
Make first patch release
bf22f5a 
Signed-off-by: Saif Ul Islam <saifulislam84210@gmail.com>
@Rubix982 Rubix982 added enhancement New feature or request github Related to GitHub, either as actions, or ideas to make a better GitHub experience overall requirements A requirement from the PRD refactor Changes related to refactoring pypi PyPI related labels Aug 20, 2021
@Rubix982 Rubix982 self-assigned this Aug 20, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2021
cbeddow
cbeddow approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@cbeddow cbeddow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks clear, nice format on the classifiers, URLs. Would add mapillary.com/developer to the list for "Developer Resources"

@Rubix982 Rubix982 merged commit cad0fc2 into main Aug 20, 2021
@Rubix982 Rubix982 deleted the Rubix982/Release-Changes branch August 20, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeddow cbeddow cbeddow approved these changes

@OmarMuhammedAli OmarMuhammedAli Awaiting requested review from OmarMuhammedAli

Assignees

@Rubix982 Rubix982

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request github Related to GitHub, either as actions, or ideas to make a better GitHub experience overall pypi PyPI related refactor Changes related to refactoring requirements A requirement from the PRD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PyPi] Restructure project to fit PyPi pushing of package Create test build for test.pypi.org

4 participants

@Rubix982 @cbeddow @facebook-github-bot