Skip to content

Fix Polygon creation in {shape,geojson}_features_controller #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbeddow merged 1 commit into from
Mar 17, 2025
Merged

Fix Polygon creation in {shape,geojson}_features_controller #149

cbeddow merged 1 commit into from
Mar 17, 2025

Conversation

@ducksoup
Copy link
Contributor

@ducksoup ducksoup commented Feb 28, 2023

shapely.geometry.shape expects as input a GeoJSON-like mapping which, in the case of a polygon, should contain a list of lists of points. The current code instead tries to append all points to a single flat list. This causes errors such as:

Traceback (most recent call last):
  File "shapely/speedups/_speedups.pyx", line 252, in shapely.speedups._speedups.geos_linearring_from_py
AttributeError: 'list' object has no attribute '__array_interface__'

This PR fixes this issue.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2023
@cbeddow cbeddow merged commit cddee9f into mapillary:main Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ducksoup @facebook-github-bot @cbeddow