[mapillary_tools] Handle SQLite database errors gracefully in cache reads#813
Merged
[mapillary_tools] Handle SQLite database errors gracefully in cache reads#813
Conversation
Summary: - Fix sqlite3.OperationalError: disk I/O error in the file handle cache from crashing the entire upload process - PersistentCache.get() now catches sqlite3.DatabaseError and returns None (cache miss) instead of propagating the exception - Cache failures are logged as warnings so they remain visible for debugging Context The upload file handle cache is a SQLite database that stores server-returned handles for already-uploaded images. It is purely an optimization to skip re-uploading — if the cache is unavailable, the server's fetch_offset endpoint confirms prior uploads at the cost of one extra HTTP round-trip per image. Previously, any SQLite error during cache lookup (disk I/O error, corrupt database, etc.) propagated up through _continue_or_fail which treated it as a fatal error, aborting the upload of all remaining images. This was observed on Windows with 4 concurrent upload workers rapidly opening/closing SQLite connections to the same cache file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache read operations could crash if the SQLite database file becomes corrupted or encounters disk I/O errors. This change adds exception handling to gracefully return None when DatabaseError exceptions occur, allowing the application to continue without the cache rather than failing entirely.