Controlling layer visibility dynamically using visibility property has no effect in v5.15.0

[sudharsanprabhu]

maplibre-gl-js version: 5.15.0

browser: Google Chrome 143.0.7499.169

Description

After upgrading to maplibre-gl-js version 5.15.0, setting a layer’s visibility to "none" no longer hides the layer.
This behavior was working as expected up to v5.14.0

Steps to Trigger Behavior

1. Add any layer to the map
2. Get the layer using map.getLayer("<LAYER_NAME>")
3. Change the visibility of the layer. Eg. layer.visibility = "none"

Link to Demonstration

v5.15.0 https://maplibre-51500.netlify.app/
v5.14.0 https://maplibre-51400.netlify.app/

Expected Behavior

The layer should be hidden when its visibility is set to "none"

Actual Behavior

Setting the visibility property of a layer has no effect on its visibility state. No errors or warnings were observed in the console

Minimum code to reproduce

const layer = map.getLayer("<LAYER_NAME>");
layer.visibility = "none";
map.redraw();

[larsmaxfield]

Is there a reason you don't use map.setLayoutProperty?

map.setLayoutProperty("<LAYER_NAME>", "visibility", "none");

*This also eliminates the need to call redraw.

[sudharsanprabhu]

Thanks for the update! That'll do

[HarelM]

This used to work since visibility was not an expression, so luck mostly.
The proper way to set visibility is setLayoutProperty as mentioned above.

[sudharsanprabhu]

Makes sense.. Thanks!