updated README.md to link to newest versions#2
Merged
Conversation
README.md has been linking to old versions of the software even though newer binaries and tarballs exist.
aalex
self-requested a review
August 17, 2019 15:22
aalex
requested changes
Aug 17, 2019
aalex
left a comment
aalex
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! You are right that we should not keep info that is not up-to-date in the readme!
For now, I am blocking this pull request, because new commits should usually go into the develop branch.
Also, perhaps we should consider moving this info into the Web site, instead.
That's in the master branch of the following repository: https://github.com/mapmapteam/mapmapteam.github.io
What do you guys think?
Contributor
Author
|
Thank you for the information. I though this pull request was for the website repository(correct me if I'm wrong). |
Member
|
Ah! You are right! I thought we were in MapMap directly! |
aalex
approved these changes
Aug 17, 2019
Member
|
It looks good to me! I will proceed with accepting your changes! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, README.md has been linking to old versions of the software even though newer binaries and tarballs exists