Load project as needed

[jlewin]

• Fixes Challenge get-by-id endpoint results in indefinite loading indicator #2642

[jlewin]

This is my take on a fix and completely understandable if it varies from a more preferred approach. If nothing else, hopefully it provides a glanceable take on the problem and helps bring about a fix.

1. Small changes were made in mapStateToProps to ensure the loaded identifiers remain available for subsequent processing
2. The retained projectId is passed into and used in loadTask to ensure the project data is available and mapped into redux state
3. References in the form of existingTask?.parent?.parent are extracted to named variables for clarity in a somewhat hard to track scope of behavior.
4. Rather than build up a complex and opaque object to pass to fetchParentProject, fetchProject is imported and used to directly to load the project with only the known identifier

This worked but seemed less ideal...

 const challenges = {};
  challenges[projectId.toString()] = {
    parent: projectId
  };
  const mockChallengeResults = {
    entities: {
      challenges: challenges,
    },
    result: projectId,
  };
  fetchParentProject(dispatch, mockChallengeResults);

versus

dispatch(fetchProject(projectId));

[jake-low]

Awesome, thank you so much for diving into this bug and putting together a PR! I'll review this after the weekend but just wanted to say thanks for contributing.

[jake-low]

LGTM! This logic for loading tasks was tricky; thanks for figuring out the bug. In the future it'd be good for us to simplify this logic so it's less error prone.