Skip to content

Comments

Updated Polish translation in categories.txt#3667

Open
psokol wants to merge 2 commits intomapsme:masterfrom
psokol:master
Open

Updated Polish translation in categories.txt#3667
psokol wants to merge 2 commits intomapsme:masterfrom
psokol:master

Conversation

@psokol
Copy link

@psokol psokol commented Jun 25, 2016

No description provided.

nl:3Bank|geld
zh-Hant:1銀行|錢
pl:3Bank|pieniądze
pl:3Placówka banku|bank|pieniądze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave "Bank" as the first option here, since it's displayed in the place page and in the categories list, and it might be more understandable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish. I think about "Bank" as the name of institution not a place and so I changed it according to this.

@matkoniecz
Copy link

@Zverik What is blocking merge? Conflicts due to long waiting time or something else?

@mpimenov
Copy link
Contributor

@matkoniecz Looks like it is the main reason. Please rebase your branch.

@matkoniecz
Copy link

@mpimenov It is not my branch, @psokol made it one year ago.

I am asking because I was unsure whatever is it a good idea to make updated PR (it makes sense if that is the main problem).

@matkoniecz
Copy link

@mpimenov I got blocked quickly due to missing documentation what makes testing whatever changes work impossible (reported as #6890)

@mpimenov
Copy link
Contributor

@matkoniecz Ah, I see. Yes, an updated PR is a good idea unless @psokol will hear us here and rebase the branch. With changes touching only data/categories.txt, I don't think you need to compile the project for this PR.

@mapsmetest
Copy link
Contributor

Jenkins asks: can anyone have a look at this request?
If you want Jenkins to compile and test this, write "test this please" or JT_TP (without the underscore in the middle).

@matkoniecz
Copy link

can anyone have a look at this request

I am waiting for response to #7026

@mapsmetest
Copy link
Contributor

Jenkins asks: can anyone have a look at this request?
If you want Jenkins to compile and test this, write "test this please" or JT_TP (without the underscore in the middle).

1 similar comment
@mapsmetest
Copy link
Contributor

Jenkins asks: can anyone have a look at this request?
If you want Jenkins to compile and test this, write "test this please" or JT_TP (without the underscore in the middle).

@mapsmetest
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@greshilov
Copy link
Contributor

Can one of the admins verify this patch?

@Zverik Zverik added the NO CLA label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants