Assess Image: Remove direct image option#82
Merged
Conversation
frozenhelium
force-pushed
the
fix/remove-direct-image-option
branch
3 times, most recently
from
1be9811 to
eada88e
Compare
tnagorra
reviewed
Jun 11, 2026
| projectAssets( | ||
| pagination: $pagination | ||
| filters: {projectId: {exact: $projectId}, inputType: {exact: OBJECT_IMAGE}, mimetype: {isNull: $withoutMimeType}} | ||
| filters: {projectId: {exact: $projectId}, inputType: {exact: OBJECT_IMAGE}, mimetype: {isNull: true}} |
Contributor
There was a problem hiding this comment.
Let's add a NOTE why we are filtering by isNull: true
tnagorra
approved these changes
Jun 11, 2026
Contributor
|
Can you also add an ADR why we are doing this for future reference. |
frozenhelium
force-pushed
the
fix/remove-direct-image-option
branch
from
eada88e to
01279a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.