Skip to content

Conversation

@ElJocho
Copy link
Collaborator

@ElJocho ElJocho commented Dec 8, 2021

@ElJocho ElJocho changed the title now working Changed comment to hashtags and moved to right section Dec 8, 2021
@ElJocho ElJocho linked an issue Dec 8, 2021 that may be closed by this pull request
@ElJocho ElJocho requested a review from Hagellach37 December 8, 2021 12:50
Copy link
Member

@Hagellach37 Hagellach37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this. I've tested it and just changed a bit. I removed the source attribute, as it is not so widely used as expected and added the created_by attribute instead. this will be more interesting as we might be able to see differences between users that used JOSM and users that used iD.

@Hagellach37 Hagellach37 merged commit 3397453 into dev Dec 8, 2021
@Hagellach37 Hagellach37 deleted the comment_to_hashtag branch December 8, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSM Changeset comments are not saved

3 participants