Skip to content

Changed comment to hashtags and moved to right section #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hagellach37 merged 2 commits into from
Dec 8, 2021
Merged

Changed comment to hashtags and moved to right section #504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080baf8
now working
ElJocho Dec 8, 2021
f283126
query osm editor instead of source
Hagellach37 Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 22 additions & 24 deletions mapswipe_workers/mapswipe_workers/utils/api_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,53 +42,51 @@ def query_osm(changeset_id: int):
return response


def add_to_properties(attribute: str, feature: dict, new_properties: dict):
"""Adds attribute to new geojson properties if it is needed."""
if attribute != "comment":
new_properties[attribute.replace("@", "")] = feature["properties"][attribute]
else:
new_properties[attribute.replace("@", "")] = feature["properties"]["tags"][
attribute
]
return new_properties


def remove_noise_and_add_user_info(json: dict) -> dict:
"""Delete unwanted information from properties."""
logger.info("starting filtering and adding extra info")

wanted_attributes = [
"@changesetId",
"@lastEdit",
"@osmId",
"@version",
"source",
"comment",
]
changeset_results = {}
missing_rows = {
"@changesetId": 0,
"@lastEdit": 0,
"@osmId": 0,
"@version": 0,
"source": 0,
"comment": 0,
"created_by": 0,
"hashtags": 0,
}

for feature in json["features"]:
new_properties = {}
for attribute in wanted_attributes:
for attribute in missing_rows.keys():
try:
new_properties = add_to_properties(attribute, feature, new_properties)
new_properties[attribute.replace("@", "")] = feature["properties"][
attribute
]
except KeyError:
missing_rows[attribute] += 1
if attribute != "hashtags":
missing_rows[attribute] += 1
changeset_id = new_properties["changesetId"]

# if changeset_id already queried, use stored result
if changeset_id not in changeset_results.keys():
changeset_results[changeset_id] = query_osm(changeset_id)
new_properties["username"] = changeset_results[changeset_id]["user"]
new_properties["userid"] = changeset_results[changeset_id]["uid"]
try:
new_properties["hashtags"] = changeset_results[changeset_id]["tags"][
"hashtags"
]
except KeyError:
missing_rows["hashtags"] += 1

try:
new_properties["created_by"] = changeset_results[changeset_id]["tags"][
"created_by"
]
except KeyError:
missing_rows["created_by"] += 1

feature["properties"] = new_properties
logger.info("finished filtering and adding extra info")
if any(x > 0 for x in missing_rows.values()):
Expand Down