feat: Gold toner & Split Grade with per-layer trims#440
Merged
Conversation
Third density-driven toner: colloidal gold plates the finest grain first — cool blue-black highlights with slight intensification on plain silver. Its covering power blends by the sulfide fraction, so over sepia it shifts toned highlights orange-red (classic combo). Strength rides the free pad slot in the toning uniforms; CPU/GPU parity covered. UI: chemical toning header and sliders hide outside B&W, colour section hides in B&W; section labels renamed.
Shadows/Highlights Grade trim each zone's contrast in ISO-R points (mid-sparing rotation about the zone density centers), global + R/G/B trims like Grade. Runs before Zone Density so the sequential composition stays monotone. Per-channel gains overflow the exposure uniforms past 256B: the unified UBO now supports multi-slot stages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gold toner
Split Grade
CharacteristicCurve, WGSL, uniform pack) withsplit_grade_deltasas the single-source helper._get_uniform_bindingcumulative offsets).Tests
make allgreen: lint + type + 1307 passed, 4 skipped.TestSplitGrade(sign convention, per-layer stacking, channel/zone locality, mid-sparing, monotone grid incl. stacked zone-density extremes, paper bounds, chart parity).