Handle strings with single and double quotes#5
Merged
marcoroth merged 1 commit intomarcoroth:mainfrom Jan 9, 2023
Merged
Conversation
In case we encounter a string with both single and double quotes, we can use a percent literal string to avoid escaping the quotes.
marcoroth
approved these changes
Jan 9, 2023
Owner
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thank you for opening this pull request @thomasklemm!
I was also thinking about this when I looked at #2, but figured it's not worth the effort to escape the quotes within the string.
But I haven't thought about the possibility with solving it via %(). So thank you for bringing that up 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we encounter a string with both single and double quotes, we can use a percent literal string to avoid escaping the quotes.
Before:
After:
