Fix iOS Harness ASan compiler path - #1417
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore the explicit Xcode
clang/clang++compiler and linker paths for the iOS Harness build.Why
The main
Harness iOSrun started failing only forHarness iOS (ASan, new architecture)after the previous cleanup removed these lines. Comparing the last green PR commit (498db21f) with the first failing PR commit (833a98f8) shows this was the only workflow diff.The failed ASan build reports:
Explicit modules is enabled but the compiler was not recognizedCould not get lib darwin pathThe workflow also installs ccache symlinks for
clang/clang++, so without the explicitxcrunpaths Xcode can pick up the launcher instead of its real compiler. The restored lines are the known-green setup.Validation
.github/workflows/harness-ios.ymlwith Ruby YAMLgit diff --check