Skip to content

Fix/packagefile location for compose applications - #179

Merged
vireshnavalli merged 3 commits into
pre-draftfrom
fix/packagefile-location
May 18, 2026
Merged

Fix/packagefile location for compose applications#179
vireshnavalli merged 3 commits into
pre-draftfrom
fix/packagefile-location

Conversation

@vireshnavalli

@vireshnavalli vireshnavalli commented May 13, 2026

Copy link
Copy Markdown
Contributor

Description

Compose app packageLocation information on margo docs is not clear. There is possibilities of users providing packageLocation as any kind of archive URL.

Issues Addressed

This PR allows user to provide packagelocation either as compose.yaml file within tar.gz or direct URL path to compose.yaml

Change Type

Please select the relevant options:

  • New enhancement (change that adds specification content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

@vireshnavalli
fix: clarified compose package location
e54a042 
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli
fix: corrected the statement for packagelocation
b414dcc 
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli
vireshnavalli requested a review from a team as a code owner May 13, 2026 08:24
@linux-foundation-easycla

linux-foundation-easycla Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

phil-abb
phil-abb reviewed May 13, 2026
View reviewed changes
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/application-description.linkml.yaml Outdated
Comment thread system-design/specification/margo-management-interface/workload-management-api-1.0.0.yaml Outdated
@vireshnavalli

vireshnavalli commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

/easycla

@vireshnavalli
fix: corrected the statement as per review comments
e9fda4f 
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli vireshnavalli self-assigned this May 14, 2026
phil-abb
phil-abb approved these changes May 14, 2026
View reviewed changes

@phil-abb phil-abb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there is an upcoming SUP to change how Docker works, but until that SUP is approved, I think this update is still helpful.

@vireshnavalli
vireshnavalli requested a review from ajcraig May 14, 2026 09:38
@vireshnavalli

vireshnavalli commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

I know there is an upcoming SUP to change how Docker works, but until that SUP is approved, I think this update is still helpful.

Yes @phil-abb, there is a SUP discussion on this from @javatask

ajcraig
ajcraig approved these changes May 14, 2026
View reviewed changes

@ajcraig ajcraig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, will be updated once the related SUP work for improving and standardizing the compose package is finalized. But good clarification here on this content.

@javatask

javatask commented May 14, 2026

Copy link
Copy Markdown

I know there is an upcoming SUP to change how Docker works, but until that SUP is approved, I think this update is still helpful.

Yes @phil-abb, there is a SUP discussion on this from @javatask

@phil-abb, This Monday, I'll ask WG members about initial feedback, and if it is generally positive, I'll try to accelerate the SUP submission process, and then it is up to you :)

@vireshnavalli vireshnavalli mentioned this pull request May 15, 2026
Merged
@vireshnavalli
vireshnavalli merged commit 3519aa7 into pre-draft May 18, 2026
12 checks passed
@javatask javatask mentioned this pull request Jul 26, 2026
Closed
javatask pushed a commit to javatask/specification that referenced this pull request Jul 26, 2026
Andrii Melashchenko Andrii Melashchenko
feat(compose): implement SUP-01 Compose OCI — The Margo Way
d3c2cda 
Implement Specification Update Proposal SUP-01 which defines the normative
Compose Archive packaging model for Margo, following the same OCI registry
pattern established for Helm components.

Schema changes (application-description.linkml.yaml):
- Make repository and revision required for all component types
- Add SemVer 2.0 pattern constraint on revision field
- Remove packageLocation and keyLocation fields (never released)

Schema changes (desired-state.linkml.yaml):
- Add optional revision attribute to Component class with SemVer pattern

Documentation (application-registry.md):
- Add Compose-specific OCI media types to Margo-Specific Media Types table
  (application/vnd.org.margo.component.compose+json and
   application/vnd.org.margo.component.compose.tar+gzip)
- Add normative Compose Archive Structure section (directory layout,
  security constraints, integrity verification)
- Add publishing workflow guidance (oras push recommended)
- Add wait semantics for Compose components

Documentation (index.md.jinja2):
- Update ComponentProperties compose table to document repository/revision
- Remove Investigation Needed block for compose properties

Examples:
- Update all compose examples to use repository/revision instead of
  packageLocation/keyLocation

Resolves: margo#168, margo#166, margo#179
SUP: specification-enhancements/proposals/compose-oci/sup-01-compose-oci.md
Breaking-Change: yes (pre-draft, no backward compat required)
Signed-off-by: Andrii Melashchenko <andrii.melashchenko@belden.com>
@javatask javatask mentioned this pull request Jul 27, 2026
Open
5 tasks
javatask added a commit to javatask/specification that referenced this pull request Jul 27, 2026
@javatask
feat(compose): implement SUP-01 Compose OCI — The Margo Way
ffd01b0 
Implement Specification Update Proposal SUP-01 which defines the normative
Compose Archive packaging model for Margo, following the same OCI registry
pattern established for Helm components.

Schema changes (application-description.linkml.yaml):
- Make repository and revision required for all component types
- Add SemVer 2.0 pattern constraint on revision field
- Remove packageLocation and keyLocation fields (never released)

Schema changes (desired-state.linkml.yaml):
- Add optional revision attribute to Component class with SemVer pattern

Documentation (application-registry.md):
- Add Compose-specific OCI media types to Margo-Specific Media Types table
  (application/vnd.org.margo.component.compose+json and
   application/vnd.org.margo.component.compose.tar+gzip)
- Add normative Compose Archive Structure section (directory layout,
  security constraints, integrity verification)
- Add publishing workflow guidance (oras push recommended)
- Add wait semantics for Compose components

Documentation (index.md.jinja2):
- Update ComponentProperties compose table to document repository/revision
- Remove Investigation Needed block for compose properties

Examples:
- Update all compose examples to use repository/revision instead of
  packageLocation/keyLocation

Resolves: margo#168, margo#166, margo#179
SUP: specification-enhancements/proposals/compose-oci/sup-01-compose-oci.md
Breaking-Change: yes (pre-draft, no backward compat required)
Signed-off-by: Andrii Melashchenko <andrii.melashchenko@belden.com>
javatask added a commit to javatask/specification that referenced this pull request Jul 30, 2026
@javatask Andrii Melashchenko
feat(compose): implement SUP-01 Compose OCI — The Margo Way
e3ae992 
Implement Specification Update Proposal SUP-01 which defines the normative
Compose Archive packaging model for Margo, following the same OCI registry
pattern established for Helm components.

Schema changes (application-description.linkml.yaml):
- Make repository and revision required for all component types
- Add SemVer 2.0 pattern constraint on revision field
- Remove packageLocation and keyLocation fields (never released)

Schema changes (desired-state.linkml.yaml):
- Add optional revision attribute to Component class with SemVer pattern

Documentation (application-registry.md):
- Add Compose-specific OCI media types to Margo-Specific Media Types table
  (application/vnd.org.margo.component.compose+json and
   application/vnd.org.margo.component.compose.tar+gzip)
- Add normative Compose Archive Structure section (directory layout,
  security constraints, integrity verification)
- Add publishing workflow guidance (oras push recommended)
- Add wait semantics for Compose components

Documentation (index.md.jinja2):
- Update ComponentProperties compose table to document repository/revision
- Remove Investigation Needed block for compose properties

Examples:
- Update all compose examples to use repository/revision instead of
  packageLocation/keyLocation

Resolves: margo#168, margo#166, margo#179
SUP: specification-enhancements/proposals/compose-oci/sup-01-compose-oci.md
Breaking-Change: yes (pre-draft, no backward compat required)
Signed-off-by: Andrii Melashchenko <andrii.melashchenko@belden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-abb phil-abb phil-abb approved these changes
@ajcraig ajcraig ajcraig approved these changes

Assignees

@vireshnavalli vireshnavalli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vireshnavalli @javatask @phil-abb @ajcraig