fix: correct success status codes on Management Interface endpoints - #196
Merged
Conversation
This resolves #195. Signed-off-by: Matthias Lechner <matlec.public@gmail.com>
phil-abb
self-requested a review
July 21, 2026 10:20
phil-abb
approved these changes
Jul 21, 2026
nilanjan-samajdar
approved these changes
Jul 23, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Matthias Lechner <matlec.public@gmail.com>
matlec
force-pushed
the
fix/capabilities-http-status
branch
from
July 23, 2026 06:19
df13590 to
ac909c9
Compare
Contributor
|
@matlec, for some reason, this PR is showing that you haven't signed off on it. Also, there is a merge conflict. Once these things are addressed we can merge it in. |
Signed-off-by: Matthias Lechner <matlec.public@gmail.com>
Contributor
Author
matlec
added a commit
that referenced
this pull request
Aug 24, 2026
Adopt pre-draft's kind/apiVersion removal from API routes and payloads (#189), the corrected success status codes (#196), the OCI compose packaging (#200), and the typo fixes. Conflict resolutions: - deployment-status.md: took pre-draft's 200/201 split for update vs create, kept our mTLS-era 400/403 descriptions and no 401 row. - device-capabilities.md: took pre-draft's PUT-only route shape and 200/201 split, kept our clientId-free paths (caller identity comes from the authenticated SPIFFE ID) and our 400/403/404 descriptions, updated the gateway examples to PUT accordingly. - device-client-onboarding.md: kept our deletion; pre-draft's edits only touch the legacy onboarding API that MIAF replaces. - workload-management-api: kept our paths without clientId and without the onboarding endpoints, dropped our POST operation in favor of pre-draft's PUT-only capabilities endpoint. Doc generation, example validation, and mkdocs build introduce no new warnings against the pre-merge tip. Signed-off-by: Matthias Lechner <matlec.public@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a spec hygiene fix.
The Device Capabilities endpoint documented
201 OKfor every successful write. That reason phrase does not exist (201isCreated,200isOK), and a single201was used for both creating and updating a document. Per RFC 9110,201 Createdis correct only when a new resource is created. An update should return200 OK. This meant a client updating an device that was already registered received201, reporting a creation that never happened.This PR aligns the Management Interface endpoints on a single convention:
201 Createdon creation,200 OKon update,204 No Contenton delete.Issues Addressed
#195
Change Type
Please select the relevant options:
Checklist