ci: enforce lint and report coverage on PRs#156
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pnpm exec oxlintstep to thetestjob. The existinglintscript isoxlint --fix(mutating), so CI runs the non-mutating variant. There is no oxlint config file, which is fine — oxlint applies its defaults.vite.config.ts): the coverage block was defined but notenabled, and itsreporterlist lackedjson-summary(required by the report action). Addedenabled: true,reportOnFailure: true, andjson-summaryto the reporter list. Provider/include/exclude unchanged.davelosert/vitest-coverage-report-action@…3c50566 # v2step (if: always(),pr-number: auto) matching codemirror-mcp. The job already haspull-requests: write.Why
The lint script and a coverage config already existed but CI never ran lint, and coverage was neither enabled nor emitting the
json-summarythe reporter needs — so coverage was effectively invisible on PRs. This turns both into visible PR gates.How verified
pnpm install --frozen-lockfilepnpm exec oxlint— exit 0 (1 pre-existingno-unused-expressionswarning, non-blocking; no source changes needed)pnpm run test— 206 passed + 1 expected-fail across 11 test files (including the Playwright browser project);coverage/coverage-summary.jsonis generated andcoverage/is gitignored.No mechanical source fixes were required. Part of the marimo-team engineering-excellence initiative to make existing-but-unenforced quality gates actually run in CI.