fix: lint diagnostics offset when statements contain comments - #162
Merged
Conversation
Parse the original statement text (comments included) instead of the comment-stripped version. node-sql-parser handles comments natively and reports positions relative to the original text, so stripping comments before parsing shifted error lines/columns in the document.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the original statement text (comments included) instead of the
comment-stripped version. node-sql-parser handles comments natively and
reports positions relative to the original text, so stripping comments
before parsing shifted error lines/columns in the document.
Summary by cubic
Fixes incorrect lint diagnostic positions when SQL statements include comments by parsing the original text (comments included). This aligns error lines/columns with the document, leveraging
node-sql-parser’s comment-aware positions.SqlStructureAnalyzerand use stripped content only to detect emptiness and determine statement type.Written for commit 6e3b4f5. Summary will update on new commits.