docs(vnext): accept parser-independent relation completion#182
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECTquery-site recognizer and narrow CTE visibility modelKey decisions
node-sql-parserValidation
873c926d66ea25Follow-up
The first implementation change is the runtime-free marimo-shaped type fixture. No production completion slice starts until that fixture compiles.
Summary by cubic
Accepts ADR 0005 to provide parser‑independent relation completion with clear catalog/provider contracts, CTE visibility, and deterministic lifecycle. Completion now works for incomplete FROM/JOIN without waiting for
node-sql-parseror worker startup, and keepsCodeMirrorintegration separate.New Features
completionPathStart, epochs, and coverage out.onDidChangesession notifications for service-originated revisions.CodeMirroradapter boundary, safe coalesced refresh oncatalog-availability, and no worker construction for this slice.Migration
createInMemoryRelationCatalog); do not emit SQL text—return decoded paths and roles.session.onDidChangeand coalesce refresh oncatalog-availability; respect the provided completion-intent lease.Written for commit d66ea25. Summary will update on new commits.