feat(vnext): expose statement boundaries#201
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Light2Dark
marked this pull request as ready for review
July 25, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statementBoundaryAtandstatementBoundariesIntersectingsession queriescodespans that exclude separator trivia and form a stricthasCodediscriminated unionVerification
c901544ff41480bb1e7ea2ddcab3af477dc8103fSummary by cubic
Expose synchronous, revision-stamped statement boundary queries in the vNext session API so editors and runners can locate executable SQL without re-lexing. Adds an exact/opaque boundary model with precise UTF-16 ranges and a
codespan for execution.session.statementBoundaryAt({ affinity, position })andsession.statementBoundariesIntersecting({ from, to }); results are frozen and include the currentrevision.extent,source, optionalterminator, lexicalendState, and acodespan that excludes separator trivia; discriminated byhasCode.reasonfor non-executable regions (procedural blocks, custom delimiters, resource limits).SqlSessionErrorwithinvalid-statement-boundary-request.@marimo-team/codemirror-sql/vnext:SqlStatementBoundary*,SqlStatementAffinity,SqlStatementLexicalEnd, and related request/result shapes.Written for commit c901544. Summary will update on new commits.