Conversation
4 tasks
Haleshot
changed the title
Haleshot
changed the title
axioms notebook
akshayka
reviewed
Feb 13, 2025
Contributor
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Great notebook! A few comments but otherwise great. Main feedback is to be very explicit when introducing new concepts. Nice work :)
|
|
||
|
|
||
| @app.cell(hide_code=True) | ||
| def _(event, mo, np, plt): |
Contributor
There was a problem hiding this comment.
I like this example! Nice :) The only thing is I don't understand the y-axis ticks, why do they go from 0 to 1? They don't seem to represent probabilities. Maybe just remove the y ticks?
Contributor
Author
There was a problem hiding this comment.
Originally wanted them for a layout sense (since I was playing around with stack and layouts). Removed them now.
Co-authored-by: Akshay Agrawal <akshay@marimo.io>
akshayka
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Referred to Definition of Probability chapter and drafted a notebook for axioms with 1 interactive element showcasing the same. Contains:
Sticking with the "testing"/practice section at the end with markdown dropdowns; referring to this comment.
TODO:
01_sets.pynotebook which currently says:"In the next lesson, we'll define probability from the ground up, using sets."
Either change the phrasing, or accommodate sets in this notebook and also define probability.
This would require incorporating the entire chapter hyperlinked above (Events & experiments, Defn of Prob, etc.).
📋 Checklist
--sandboxREADME.md