Conversation
ghost
commented
Apr 25, 2024
ghost
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "lodash-es": "^4.17.21", | ||
| "lucide-react": "^0.338.0", | ||
| "lz-string": "^1.5.0", | ||
| "mathjs": "^12.4.2", |
There was a problem hiding this comment.
i think youll want to run pnpm install in cd frontend, and commit the changes to the lockfile
There was a problem hiding this comment.
maybe can remove this with the suggestion below
There was a problem hiding this comment.
I've updated the lockfile, but don't know whether it's right
|
|
||
| return Math.trunc(value) === 0 | ||
| ? // No integer part, use scientific notation | ||
| format(value, { notation: "auto", precision: 2 }) |
There was a problem hiding this comment.
the browser has this built in now. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#scientific
would that work instead and avoid the extra dep? we can lowercase the e aswell to match this formatting.
new Intl.NumberFormat("en-US", {
notation: "scientific",
}).format(987654321);There was a problem hiding this comment.
I think there is a bug for this, the slider would disappear after some dragging, so I retain to mathjs
| assert "Invalid bounds" in str(e.value) | ||
|
|
||
|
|
||
| def test_slider_exclusive_args() -> None: |
There was a problem hiding this comment.
can we add a test for empty steps (not sure how we want to handle) and invalid bounds (value is not in steps)
| # cast to floats | ||
| assert isinstance(num, float) | ||
|
|
||
| slider = ui.range_slider(steps=[1, 3, 6, 10, 17, 20], value=[3, 17]) |
There was a problem hiding this comment.
can we add a test for empty steps (not sure how we want to handle) and invalid bounds (value is not in steps)
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.6-dev4 |
1 participant
