Skip to content

feat: add outline as a panel while in edit-mode#267

Merged
mscolnick merged 2 commits into
mainfrom
ms/outline
Oct 27, 2023
Merged

feat: add outline as a panel while in edit-mode#267
mscolnick merged 2 commits into
mainfrom
ms/outline

Conversation

@mscolnick

@mscolnick mscolnick commented Oct 27, 2023

Copy link
Copy Markdown
Contributor
  • this is just in editor mode, until we get more feedback in app-mode / how this could be handled (app-config, always, mo.toc(), etc)
  • we don't handle duplicate headers between different cells, we just go to the first header. i think this is ok as we likely want the user to define unique headers. i'd propose we can handle this based on feedback

Screenshot 2023-10-27 at 1 09 23 PM

@vercel

vercel Bot commented Oct 27, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 7:06pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 7:06pm

@akshayka

Copy link
Copy Markdown
Contributor

Bug in scrolling to heading in long documents

scroll-to-heading-bug.webm

akshayka
akshayka previously approved these changes Oct 27, 2023

@akshayka akshayka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved modulo nested headings with same title --- nice work!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants