Skip to content

Comments

improvement: print python code output for Ibis in mo.ui.dataframe#4129

Merged
mscolnick merged 6 commits intomarimo-team:mainfrom
szst11:main
Apr 8, 2025
Merged

improvement: print python code output for Ibis in mo.ui.dataframe#4129
mscolnick merged 6 commits intomarimo-team:mainfrom
szst11:main

Conversation

@szst11
Copy link
Contributor

@szst11 szst11 commented Mar 17, 2025

📝 Summary

enables the mo.ui.dataframe to create python code

Fixes #2267

🔍 Description of Changes

The python_print_ibis function is now able to provide proper ibis code like it is already available for Pandas and Polars.

📋 Checklist

  • [x ] I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • [ x] I have added tests for the changes made.
  • [x ] I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

szst11 added 4 commits March 17, 2025 14:44
test for ibis python_print_ibis transferred from polars
python_code needs original column names not from the response
Ibis preparations for proper python code
enable python_print_ibis
@vercel
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 7:49am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 7:49am

@github-actions
Copy link

github-actions bot commented Mar 17, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mscolnick
Copy link
Contributor

hey @szst11! great work on this so far. anything we can do to help get this over the line?

@szst11
Copy link
Contributor Author

szst11 commented Apr 7, 2025

hey @mscolnick ,
Sorry for the delay! This is my first time ever github pull-requet :-)

I have read the CLA Document and I hereby sign the CLA.

@mscolnick
Copy link
Contributor

@szst11 , the check is a bit picky. can you write the CLA in its own comment. i am also running typecheck and lint

@szst11
Copy link
Contributor Author

szst11 commented Apr 7, 2025

I have read the CLA Document and I hereby sign the CLA

@mscolnick
Copy link
Contributor

@szst11 there are a couple lint issues if you can check them out:

verifiable with: hatch run lint

You can also typecheck with hatch run typecheck:check

correction of lint failure
@mscolnick
Copy link
Contributor

thanks @szst11

@mscolnick mscolnick merged commit 227e1f5 into marimo-team:main Apr 8, 2025
5 checks passed
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.6-dev9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ibis support in ui.dataframe should output python code

2 participants